feat(content-separator): allow ContentSeparator in Menus #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps <ContentSeperator> for use in Menus
Since styling is broken when a component is provided, move wrapper to wrap all titles
nataliadelmar
approved these changes
Sep 24, 2024
dominiccarrington
changed the title
dominiccarrington
changed the title
shnaaz
reviewed
Sep 25, 2024
src/components/MenuSelectionGroup/MenuSelectionGroup.style.scss
Outdated
Show resolved
Hide resolved
use Text[type='body-secondary'] instead
|
Tested with Cantina, works fine |
shnaaz
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update <ContentSeparator> to be classed as a valid component in <Menu>, <MenuSection> and <MenuSelectionGroup>